Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix complete after some special expr. #1641

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: fix complete after some special expr. #1641

merged 1 commit into from
Sep 10, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 10, 2024

fix complete after some special expr. No symbol will be added after these expressions.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

Peefy
Peefy approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10792356825

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 70.56%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/advanced_resolver/node.rs 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/ast.rs 1 71.36%
kclvm/tools/src/LSP/src/tests.rs 1 98.6%
Totals Coverage Status
Change from base Build 10791472429: -0.01%
Covered Lines: 51217
Relevant Lines: 72586
💛 - Coveralls

@Peefy Peefy merged commit ded5e87 into kcl-lang:main Sep 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peefy Peefy Peefy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] No completion items for the string variable in the right side of the if compare condition expression
3 participants
@He1pa @coveralls @Peefy